Re: add types to index storage params on doc - Mailing list pgsql-hackers

On 2020-Mar-16, Atsushi Torikoshi wrote:

> Thanks for your comments!
> 
> On Mon, Mar 16, 2020 at 11:49 AM Fujii Masao <masao.fujii@oss.nttdata.com>
> wrote:
> 
> > -    <term><literal>buffering</literal>
> > +    <term><literal>buffering</literal> (<type>string</type>)
> >
> > Isn't it better to use "enum" rather than "string"?
> > In the docs about enum GUC parameters, "enum" is used there.
> 
> Agreed. I've fixed it to "enum".
> 
> But I'm now wondering about the type of check_option[3], [4].
> Because I decide the type to "string" referring to check_option, which is
> the other element of  enumRelOpts in reloptions.c.
> 
> Should I also change it to "enum"?

Yeah, these were strings until recently (commit 773df883e8f7 Sept 2019).

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services