Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date
Msg-id 20200306011006.GC52814@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h  (David Steele <david@pgmasters.net>)
Responses Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
List pgsql-committers
On Thu, Mar 05, 2020 at 07:58:50PM -0500, David Steele wrote:
> Yeah, keeping BLKSZ a constant is pretty important for performance. That's
> one of the main reasons that we only support the default.

Doing something is not complicated, now how would people like to do
it?  Here are the options I can think of:
1) A TAP test, which bypasses the tests if the page size is not 8k.
2) A test for src/test/regress/, with a method similar to what we do
for collate.sql for the compilations without ICU.

In both cases mentioned here, we would need a SQL function to handle
the work.
--
Michael

Attachment

pgsql-committers by date:

Previous
From: David Steele
Date:
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Next
From: David Steele
Date:
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h