useless RangeIOData->typiofunc - Mailing list pgsql-hackers

From Alvaro Herrera
Subject useless RangeIOData->typiofunc
Date
Msg-id 20200304215711.GA8732@alvherre.pgsql
Whole thread Raw
Responses Re: useless RangeIOData->typiofunc  (Paul Jungwirth <pj@illuminatedcomputing.com>)
Re: useless RangeIOData->typiofunc  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I noticed while going over the multirange types patch that it adds a
pointless typiofunc cached OID to a struct used for I/O functions'
fn_extra.  It seems to go completely unused, so I checked range types
(which this was cribbed from) and indeed, it is completely unused there
either.  My guess is that it was in turn cribbed from array's
ArrayMetaState, which is considerably more sophisticated; I suspect
nobody noticed that caching it was pointless.

Here's a patch to remove it from rangetypes.c.  It doesn't really waste
much memory anyway, but removing it lessens the cognitive load by one or
two bits.

-- 
Álvaro Herrera

Attachment

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: error context for vacuum to include block number
Next
From: Daniel Gustafsson
Date:
Subject: Re: Ought to use heap_multi_insert() for pg_attribute/dependinsertions?