Re: Print physical file path when checksum check fails - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Print physical file path when checksum check fails
Date
Msg-id 20200219042804.GD2288@paquier.xyz
Whole thread Raw
In response to Re: Print physical file path when checksum check fails  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: Print physical file path when checksum check fails
List pgsql-hackers
On Wed, Feb 19, 2020 at 01:07:36PM +0900, Kyotaro Horiguchi wrote:
> If we also verify checksum in md layer, callback is overkill since the
> immediate caller consumes the event immediately.  We can signal the
> error by somehow returning a file tag.

FWIW, I am wondering if there is any need for a change here and
complicate more the code.  If you know the block number, the page size
and the segment file size you can immediately guess where is the
damaged block.  The first information is already part of the error
message, and the two other ones are constants defined at
compile-time.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Parallel copy
Next
From: Tom Lane
Date:
Subject: Re: Resolving the python 2 -> python 3 mess