Re: reindex concurrently and two toast indexes - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: reindex concurrently and two toast indexes
Date
Msg-id 20200218061913.GJ4176@paquier.xyz
Whole thread Raw
In response to Re: reindex concurrently and two toast indexes  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: reindex concurrently and two toast indexes
List pgsql-hackers
On Tue, Feb 18, 2020 at 07:06:25AM +0100, Julien Rouhaud wrote:
> On Tue, Feb 18, 2020 at 6:30 AM Michael Paquier <michael@paquier.xyz> wrote:
>> Hmm.  There could be an argument here for skipping invalid toast
>> indexes within reindex_index(), because we are sure about having at
>> least one valid toast index at anytime, and these are not concerned
>> with CIC.
>
> Or even automatically drop any invalid index on toast relation in
> reindex_relation, since those can't be due to a failed CIC?

No, I don't like much outsmarting REINDEX with more index drops than
it needs to do.  And this would not take care of the case with REINDEX
INDEX done directly on a toast index.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [Patch] Make pg_checksums skip foreign tablespace directories
Next
From: Julien Rouhaud
Date:
Subject: Re: reindex concurrently and two toast indexes