Re: Dead code in adminpack - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Dead code in adminpack
Date
Msg-id 20200213114528.GL1520@paquier.xyz
Whole thread Raw
In response to Dead code in adminpack  (Antonin Houska <ah@cybertec.at>)
List pgsql-hackers
On Thu, Feb 13, 2020 at 12:15:39PM +0100, Antonin Houska wrote:
> I've noticed that convert_and_check_filename() is always passed false for the
> "logAllowed" argument - someone probably forgot to remove the argument when it
> was decided that log files are no longer accepted. If the argument was removed,
> the function would become a bit simpler, see the patch.

This routine was originally named absClusterPath(), but even at its
origin point (fe59e56) this argument has never been used.  So no
objections to clean up that.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Suraj Kharage
Date:
Subject: Re: allow frontend use of the backend's core hashing functions
Next
From: Michael Paquier
Date:
Subject: Re: client-side fsync() error handling