Re: 2020-02-13 Press Release Draft - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: 2020-02-13 Press Release Draft
Date
Msg-id 20200210172357.GA20871@alvherre.pgsql
Whole thread Raw
In response to 2020-02-13 Press Release Draft  ("Jonathan S. Katz" <jkatz@postgresql.org>)
Responses Re: 2020-02-13 Press Release Draft
List pgsql-hackers
On 2020-Feb-10, Jonathan S. Katz wrote:

> * Several figures for GSSAPI support, including having libpq accept all
> GSS-related connection parameters even if the GSSAPI code is not compiled in.

"figures"?

> If you had previously executed `TRUNCATE .. CASCADE` on a sub-partition of a
> partitioned table, and the partitioned table has a foreign-key reference from
> another table, you will have to run the `TRUNCATE` on the other table as well.
> The issue that caused this is fixed in this release, but you will have to
> perform this step to ensure all of your data is cleaned up.

I'm unsure about the "will" in the "you will have to run the TRUNCATE".
If the table is truncated then reloading, then the truncation might be
optional.  I would change the "will" to "may".  At the same time I
wonder if it would make sense to provide a query that would return any
rows violating such constraints; if empty then there's no need to
truncate.  On the other hand, if not empty, perhaps we can suggest to
delete just those rows rather than truncating everything.  Perhaps we
can quote ri_triggers.c's RI_Initial_Check,

    /*----------
     * The query string built is:
     *  SELECT fk.keycols FROM [ONLY] relname fk
     *   LEFT OUTER JOIN [ONLY] pkrelname pk
     *   ON (pk.pkkeycol1=fk.keycol1 [AND ...])
     *   WHERE pk.pkkeycol1 IS NULL AND
     * For MATCH SIMPLE:
     *   (fk.keycol1 IS NOT NULL [AND ...])
     * For MATCH FULL:
     *   (fk.keycol1 IS NOT NULL [OR ...])
     *
     * We attach COLLATE clauses to the operators when comparing columns
     * that have different collations.
     *----------
     */

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Konstantin Knizhnik
Date:
Subject: Re: Yet another vectorized engine
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Erase the distinctClause if the result is unique by definition