Re: widen vacuum buffer counters - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: widen vacuum buffer counters
Date
Msg-id 20200205201808.GA30278@alvherre.pgsql
Whole thread Raw
In response to Re: widen vacuum buffer counters  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2020-Jan-31, Tom Lane wrote:

> Also, %zd is the wrong format code for int64.  Recommended practice
> these days is to use "%lld" with an explicit cast of the printf argument
> to long long (just to be sure).  That doesn't work safely before v12,
> and if you did insist on back-patching further, you'd need to jump
> through hoops to avoid having platform-specific format codes in a
> translatable string.  (The side-effects for translation seem like
> an independent argument against back-patching.)

Pushed with that change; did not backpatch, because I don't think it's
really worth the possible breakage :-)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Memory-Bounded Hash Aggregation
Next
From: Mahendra Singh Thalor
Date:
Subject: Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager