Re: BufFileRead() error signalling - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: BufFileRead() error signalling
Date
Msg-id 20200130052751.GD1956@paquier.xyz
Whole thread Raw
In response to Re: BufFileRead() error signalling  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Wed, Jan 29, 2020 at 10:01:31AM -0500, Robert Haas wrote:
> Your grep misses one instance of 'read only %d of %d bytes' because
> you grepped for %zu specifically, but that doesn't really change the
> overall picture.

Yes, the one in pg_checksums.c.  That could actually be changed with a
cast to Size.  (Note that there is a second one related to writes but
there is a precedent in md.c, and a similar one in rewriteheap.c..)

Sorry for the digression.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Tid scan increments value of pg_stat_all_tables.seq_scan. (butnot seq_tup_read)
Next
From: Ian Barwick
Date:
Subject: Prevent pg_basebackup running as root