On Thu, Jan 09, 2020 at 08:09:29PM -0500, Tom Lane wrote:
> TBH, my recommendation would be to drop *all* of these likely()
> and unlikely() calls. What evidence have you got that those are
> meaningfully improving the quality of the generated code? And if
> they're buried inside macros, they certainly aren't doing anything
> useful in terms of documenting the code.
Yes. I am wondering if we should not rework this part of the logging
with something like the attached. My 2c, thoughts welcome.
--
Michael
