Re: Drongo vs. 9.4 initdb TAP test - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Drongo vs. 9.4 initdb TAP test
Date
Msg-id 20191223005341.GA6890@paquier.xyz
Whole thread Raw
In response to Drongo vs. 9.4 initdb TAP test  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Drongo vs. 9.4 initdb TAP test  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sun, Dec 22, 2019 at 07:24:09PM -0500, Tom Lane wrote:
> This test is passing in the newer branches --- evidently due to
> the 9.5-era commit 1a629c1b1, which removed this TAP script's
> dependency on "rm -rf".  So we should either back-patch that
> commit into 9.4 or undo whatever configuration change caused
> drongo to try to run more tests.  I favor the former.

I would prefer simply removing the dependency of rm -rf in the tests,
even if that's for a short time as 9.4 is EOL in two months.  A
back-patch applies without conflicts, and the tests are able to pass.
Would you prefer doing it yourself?  I have not checked yet on
Windows, better to make sure that it does not fail.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Drongo vs. 9.4 initdb TAP test
Next
From: Andres Freund
Date:
Subject: Re: smgr vs DropRelFileNodeBuffers() vs filesystem state vs nocritical section