Re: psql small improvement patch - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: psql small improvement patch
Date
Msg-id 20191221200806.GI11527@momjian.us
Whole thread Raw
In response to Re: psql small improvement patch  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: psql small improvement patch  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sat, Dec  7, 2019 at 12:58:12PM -0500, Tom Lane wrote:
> "Shinoda, Noriyoshi (PN Japan A&PS Delivery)" <noriyoshi.shinoda@hpe.com> writes:
> > I propose a small improvement to the psql command.
> > Currently, psql's help/quit/exit command needs to start from the first position of the prompt.
> > The attached patch allows the command to be executed ignoring leading white spaces.
> 
> Please read the (very long) thread in which this behavior was designed:
> 
> https://www.postgresql.org/message-id/flat/CACYgWUnvCSeiFXyw9%2BVqHVAd%2BfUxYhsrGxacRGJao63gznV9UQ%40mail.gmail.com
> 
> Allowing whitespace before the special command was part of the design
> early on, eg my proposal at
> 
> https://www.postgresql.org/message-id/30157.1513058300%40sss.pgh.pa.us
> 
> but we eventually decided not to, see further down at
> 
> https://www.postgresql.org/message-id/20180125204630.GA27619%40momjian.us
> 
> If you want to reverse that decision you need to present cogent arguments
> why, not just send in a patch.

Do we need a C comment to document why no whitespace is allowed
before it?

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Bogus logic in RelationBuildPartitionDesc
Next
From: Julien Rouhaud
Date:
Subject: Re: Misleading comment in pg_upgrade.c