Re: pgsql: Add a regression test for allow_system_table_mods - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Add a regression test for allow_system_table_mods
Date
Msg-id 20191203041247.GD1634@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Add a regression test for allow_system_table_mods  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Add a regression test for allow_system_table_mods  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-committers
On Mon, Dec 02, 2019 at 10:11:40AM -0500, Tom Lane wrote:
> One way would be to provide a variant expected-file, but that's not going
> to be fun for future maintenance of the test script.  Another simple
> answer is to crank up client_min_messages for this one test to hide the
> WARNING, but you could conjure scenarios where that misses something
> important.  (Of course, not running the test at all would also miss
> any such issue.)

Alternate output files should be IMO avoided if we can, so if I were
to choose sneaking a SET client_min_messages would be fine, but only
for the second create tablespace..
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix failures with TAP tests of pg_ctl on Windows
Next
From: Michael Paquier
Date:
Subject: pgsql: Remove XLogFileNameP() from the tree