On Thu, Nov 07, 2019 at 02:41:29AM +0900, Fujii Masao wrote:
> I created the problematic WAL file artificially by using
> pg_logical_emit_message() and sucessfully reproduced
> the error.
Good idea. I didn't know this one.
> I attached the WAL file that I created. You can
> reproduce the issue by
>
> pg_waldump 000000010000000000000008 -s 0/08002028
Assertion failure reproduced here.
> The patch looks good to me. Barrying any objection, I will commit it.
> XLogFindNextRecord() must return the valid record starting position,
> but currently could return the starting position of WAL page
> (not valid WAL record) in the case that you described. This is
> the cause of the issue.
No issues from here, thanks for taking care of it.
--
Michael
