Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdwmessage. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdwmessage.
Date
Msg-id 20191106041312.GD1604@paquier.xyz
Whole thread Raw
In response to Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.  (Etsuro Fujita <etsuro.fujita@gmail.com>)
Responses Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.  (Etsuro Fujita <etsuro.fujita@gmail.com>)
List pgsql-hackers
Tree view 
On Wed, Nov 06, 2019 at 12:57:10PM +0900, Etsuro Fujita wrote:
> Thanks for the patch!  I added the commit message.  Does that make
> sense?  If there are no objections, I'll apply the patch to all
> supported branches.

"postgres_fdw foreign tables" sounds weird to me.  Could "foreign
tables using postgres_fdw" be a better wording?  I am wondering as
well if we should not split this information into two parts: one for
the actual error message which only mentions foreign tables, and a
second one with a hint to mention that postgres_fdw has been used.

We could have more test cases with 2PC in this module, not necessarily
the responsibility of this patch, but while we're on it..
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Andrew Gierth
Date:
Subject: Re: Keep compiler silence (clang 10, implicit conversion from 'long' to 'double' )
Next
From: Michael Paquier
Date:
Subject: Re: Checking return value of SPI_execute