Re: Missing error_context_stack = NULL in AutoVacWorkerMain() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Missing error_context_stack = NULL in AutoVacWorkerMain()
Date
Msg-id 20191023013111.GA3286@paquier.xyz
Whole thread Raw
In response to Re: Missing error_context_stack = NULL in AutoVacWorkerMain()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Oct 21, 2019 at 12:53:27AM -0400, Tom Lane wrote:
> Oh --- looking closer, proc_exit itself will clear error_context_stack
> before doing much.  So a problem would only occur if we suffered an error
> during EmitErrorReport, which seems somewhat unlikely.  Still, it's bad
> that this code isn't like all the others.  There's certainly no downside
> to clearing the pointer.

Good point about index predicates/expressions.  There is the elog()
hook as well in the area, and it's hard to predict how people use
that.  So applied and back-patched down 9.4.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Bug about drop index concurrently
Next
From: Amit Langote
Date:
Subject: Re: [PATCH] Do not use StdRdOptions in Access Methods