Re: v12.0: segfault in reindex CONCURRENTLY - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: v12.0: segfault in reindex CONCURRENTLY
Date
Msg-id 20191017085024.GG17439@paquier.xyz
Whole thread Raw
In response to Re: v12.0: segfault in reindex CONCURRENTLY  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: v12.0: segfault in reindex CONCURRENTLY  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Thu, Oct 17, 2019 at 05:33:22AM -0300, Alvaro Herrera wrote:
> Hmm, I wonder if it isn't the right solution to set 'progress' to false
> in that spot, instead.  index_drop says it must only be called by the
> dependency machinery; are we depending on that to pass-through the need
> to update progress status?  I'm going over that code now.

pgstat_progress_end_command() is done for REINDEX CONCURRENTLY after
the concurrent drop, so it made sense to me to still report any PID
REINDEX CONC is waiting for at this stage.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] Block level parallel vacuum
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Change atoi to strtol in same place