Re: dropping column prevented due to inherited index - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: dropping column prevented due to inherited index
Date
Msg-id 20191010041337.GE1852@paquier.xyz
Whole thread Raw
In response to Re: dropping column prevented due to inherited index  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: dropping column prevented due to inherited index
List pgsql-hackers
On Wed, Oct 09, 2019 at 06:36:35AM -0300, Alvaro Herrera wrote:
> Right, something like that.  Needs a comment to explain what we do and
> how recursing=true correlates with addrs=NULL, I think.  Maybe add an
> assert.

Yes, that would be a thing to do.  So I have added more comments
regarding that aspect, an assertion, and more tests with a partitioned
table without any children, and an actual check that all columns have
been dropped in the leaves of the partition tree.  How does that look?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Remove pqsignal() from libpq's official exports list.
Next
From: Masahiko Sawada
Date:
Subject: Re: maintenance_work_mem used by Vacuum