Re: dropping column prevented due to inherited index - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: dropping column prevented due to inherited index
Date
Msg-id 20191004085714.GC1829@paquier.xyz
Whole thread Raw
In response to Re: dropping column prevented due to inherited index  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: dropping column prevented due to inherited index
List pgsql-hackers
On Thu, Oct 03, 2019 at 09:18:12AM -0300, Alvaro Herrera wrote:
> Hmm.  I wonder if we shouldn't adopt the coding pattern we've used
> elsewhere of collecting all columns to be dropped first into an
> ObjectAddresses array, then use performMultipleDeletions.

+1.  That's the common pattern these days, because that's more
performant.  I think that the patch should have regression tests.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Include RELKIND_TOASTVALUE in get_relkind_objtype
Next
From: Ashutosh Sharma
Date:
Subject: Re: refactoring - share str2*int64 functions