Re: Hooks for session start and end, take two - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Hooks for session start and end, take two
Date
Msg-id 20191001031722.GE2781@paquier.xyz
Whole thread Raw
In response to Re: Hooks for session start and end, take two  (Fabrízio de Royes Mello <fabriziomello@gmail.com>)
Responses Re: Hooks for session start and end, take two
List pgsql-hackers
On Mon, Sep 30, 2019 at 02:46:42PM -0300, Fabrízio de Royes Mello wrote:
> Makes sense to me. I become a reviewer and run all tests (make check &&
> make check-world) and everything is ok. Changed status to "ready for
> commiter".

Thanks.  There was an extra problem in the module hidden in the logs
of the regression tests: the autovacuum launcher has a backend ID
assigned at the moment of the session end hook (not the start), but it
is connected to no databases so I added a check on that in the start
and end hooks of the module.  That's more logic this way anyway as we
run a transaction in the test, and much better than using directly
GetUserIdAndSecContext() which would not assert for an invalid user
ID.  And done with e788bd9.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Connections hang indefinitely while taking a gin index's LWLockbuffer_content lock(PG10.7)
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Attempt to consolidate reading of XLOG page