Re: pg_wal/RECOVERYHISTORY file remains after archive recovery - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_wal/RECOVERYHISTORY file remains after archive recovery
Date
Msg-id 20190930080340.GO2888@paquier.xyz
Whole thread Raw
In response to Re: pg_wal/RECOVERYHISTORY file remains after archive recovery  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: pg_wal/RECOVERYHISTORY file remains after archive recovery
List pgsql-hackers
On Mon, Sep 30, 2019 at 12:53:58PM +0900, Masahiko Sawada wrote:
> I think that the above checks are always true because isnt() function
> checks if the 1st argument and 2nd argument are not the same.

Dammit.  I overlooked this part of the module's doc.

> I've attached the updated version patch including the tests. Please
> review it.

Thanks, your test allows to reproduce the original problem, so that's
nice.  I don't have much to say, except some improvements to the
comments of the test as per the attached.  What do you think?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Don't codegen deform code for virtual tuples in expr eval forscan fetch
Next
From: Masahiko Sawada
Date:
Subject: Re: pg_wal/RECOVERYHISTORY file remains after archive recovery