Postgres Pro
Downloads
Home   >   mailing lists

Re: PATCH: standby crashed when replay block which truncated instandby but failed to truncate in master node - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: PATCH: standby crashed when replay block which truncated instandby but failed to truncate in master node
Date
Msg-id 20190925032403.GF1815@paquier.xyz
Whole thread Raw
In response to Re: PATCH: standby crashed when replay block which truncated instandby but failed to truncate in master node  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: PATCH: standby crashed when replay block which truncated instandby but failed to truncate in master node
List pgsql-hackers
Tree view 
On Tue, Sep 24, 2019 at 02:48:16PM +0900, Kyotaro Horiguchi wrote:
> Of course I found no *explicit* ones. But I found one
> ereport(DEBUG1 in register_dirty_segment. So it will work at
> least for the case where fsync request queue is full.

Exactly.  I have not checked the patch in details, but I think that
we should not rely on the assumption that no code paths in this area do
not check after CHECK_FOR_INTERRUPTS() as smgrtruncate() does much
more than just the physical segment truncation.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] src/test/modules/dummy_index -- way to test reloptionsfrom inside of access method
Next
From: Amit Kapila
Date:
Subject: Re: range test for hash index?