Re: [patch]socket_timeout in interfaces/libpq - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [patch]socket_timeout in interfaces/libpq
Date
Msg-id 20190911045854.GH1953@paquier.xyz
Whole thread Raw
In response to Re: [patch]socket_timeout in interfaces/libpq  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [patch]socket_timeout in interfaces/libpq
List pgsql-hackers
On Tue, Sep 10, 2019 at 03:38:21PM +0900, Michael Paquier wrote:
> I recall having a negative impression on the patch when first looking
> at it, and still have the same impression when looking at the last
> version.  Just with a quick look, assuming that you can bypass all
> cleanup operations normally taken by pqDropConnection() through a
> hijacking of pqWait() is not fine as this routine explicitely assumes
> to *never* have a timeout for its wait.

By the way, Fabien, you are marked as a reviewer of this patch since
the end of June.  Are you planning to review it?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [bug fix] Produce a crash dump before main() on Windows
Next
From: Andrey Borodin
Date:
Subject: Re: ICU for global collation