Re: Useless code in RelationCacheInitializePhase3 - Mailing list pgsql-hackers

From Alvaro Herrera from 2ndQuadrant
Subject Re: Useless code in RelationCacheInitializePhase3
Date
Msg-id 20190910163417.GA5859@alvherre.pgsql
Whole thread Raw
In response to Re: Useless code in RelationCacheInitializePhase3  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hello,

On 2019-Apr-13, Tom Lane wrote:

> Andres Freund <andres@anarazel.de> writes:

> > I think it probably would work for catalog tables, as it's coded right
> > now. There's no catalog lookups RelationInitTableAccessMethod() for
> > tables that return true for IsCatalogTable(). In fact, I think we should
> > apply something like:
> 
> Makes sense, and I'd also add some comments pointing out that there had
> better not be any catalog lookups when this is called for a system
> catalog.

I think this was forgotten ...

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera from 2ndQuadrant
Date:
Subject: Re: Libpq support to connect to standby server as priority
Next
From: Peter Eisentraut
Date:
Subject: another look at macOS SIP