Re: Misleading comment in tuplesort_set_bound - Mailing list pgsql-hackers

From Alvaro Herrera from 2ndQuadrant
Subject Re: Misleading comment in tuplesort_set_bound
Date
Msg-id 20190905205657.GA27458@alvherre.pgsql
Whole thread Raw
In response to Re: Misleading comment in tuplesort_set_bound  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Misleading comment in tuplesort_set_bound
List pgsql-hackers
On 2019-Aug-26, Tom Lane wrote:

> James Coleman <jtc331@gmail.com> writes:

> I think the comment is fine as-is.  Perhaps the code would be clearer
> though, if we merged those two asserts into one?
> 
>     /* Assert we're called before loading any tuples */
>     Assert(state->status == TSS_INITIAL &&
>            state->memtupcount == 0);

Makes sense to me.  James, do you want to submit a new patch?

> I'm not totally sure about the usefulness/relevance of the two
> assertions following these, but they could likely do with their
> own comment(s), because this one surely isn't covering them.


-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [Patch] Invalid permission check in pg_stats for functional indexes
Next
From: James Coleman
Date:
Subject: Re: Misleading comment in tuplesort_set_bound