Re: pg_promote() can cause busy loop - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_promote() can cause busy loop
Date
Msg-id 20190905020935.GA22147@paquier.xyz
Whole thread Raw
In response to pg_promote() can cause busy loop  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: pg_promote() can cause busy loop
List pgsql-hackers
On Thu, Sep 05, 2019 at 10:53:19AM +0900, Fujii Masao wrote:
> It's ok to use PG_RETURN_BOOL(false) instead of breaking out of the loop
> in that case. Which would make the code simpler.

Okay.  I would have done so FWIW.

> But I don't think it's worth warning about postmaster death here
> because a backend will emit FATAL message like "terminating connection
> due to unexpected postmaster exit" in secure_read() after
> pg_promote() returns false.

Good point, that could be equally confusing.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: block-level incremental backup
Next
From: Michael Paquier
Date:
Subject: Re: using explicit_bzero