Re: remove "msg" parameter from convert_tuples_by_name - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: remove "msg" parameter from convert_tuples_by_name
Date
Msg-id 20190903185201.GA14872@alvherre.pgsql
Whole thread Raw
In response to Re: remove "msg" parameter from convert_tuples_by_name  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: remove "msg" parameter from convert_tuples_by_name
List pgsql-hackers
On 2019-Aug-07, Amit Langote wrote:

> If we're reducing the message string to occur only once in the source
> code, can we maybe write it to be more informative?  I wonder if users
> aren't normally supposed to see this message?

Grepping for the messages given to convert_tuples_by_position yields
quite a few matches in regression test output, but none for the one in
convert_tuples_by_name.  This makes me think that it isn't user-visible,
unless things go very wrong.

Pushed the patch, thanks.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Change ereport level for QueuePartitionConstraintValidation
Next
From: Pierre Ducroquet
Date:
Subject: Re: [Patch] Invalid permission check in pg_stats for functional indexes