Re: Statement timeout in pg_rewind - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Statement timeout in pg_rewind
Date
Msg-id 20190828025133.GC1965@paquier.xyz
Whole thread Raw
In response to Re: Statement timeout in pg_rewind  (Alexander Kukushkin <cyberdemn@gmail.com>)
Responses Re: Statement timeout in pg_rewind  (Alexander Kukushkin <cyberdemn@gmail.com>)
List pgsql-hackers
On Tue, Aug 27, 2019 at 10:45:27AM +0200, Alexander Kukushkin wrote:
> Done, please see the next version attached.

I have made the new error message consistent with run_simple_query to
avoid more work to translators and because it is possible to know
immediately the code path involved thanks to the SQL query, then
applied the fix down to 9.5 where pg_rewind has been added.  Please
note that your patch had a warning as "result" is not needed in
run_simple_command().

idle_in_transaction_session_timeout only applies to 9.6 and newer
versions.  lock_timeout (imagine a concurrent lock on pg_class for
example) and statement_timeout can cause issues, but the full set gets
disabled as your patch did and as mentioned upthread.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Ian Barwick
Date:
Subject: Re: [PATCH] Make configuration file "include" directive handling morerobust
Next
From: Michael Paquier
Date:
Subject: Re: Cleanup isolation specs from unused steps