Re: [HACKERS] [PATCH] pageinspect function to decode infomasks - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
Date
Msg-id 20190823032732.GA5275@paquier.xyz
Whole thread Raw
In response to Re: [HACKERS] [PATCH] pageinspect function to decode infomasks  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: [HACKERS] [PATCH] pageinspect function to decode infomasks  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
On Fri, Aug 23, 2019 at 11:09:44AM +0900, Masahiko Sawada wrote:
> While updating the doc I realized that
> perhaps we should have the new section for heap and put the
> descriptions of heap functions into it rather than having them as
> general functions. If we need this change it is for PG12. I will
> register only the new feature patch to the next Commit Fest.

I agree with the new heap section, and your patch on that looks good.
While on it, I have one suggestion: fsm_page_contents does not have an
example of query.  Could we add one while on it?  An example
consistent with the other function's examples:
=# SELECT fsm_page_contents(get_raw_page('pg_class', 'fsm', 0));
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
Next
From: Melanie Plageman
Date:
Subject: Re: Cleanup isolation specs from unused steps