Postgres Pro
Downloads
Home   >   mailing lists

Re: concerns around pg_lsn - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: concerns around pg_lsn
Date
Msg-id 20190804035701.GA7309@alvherre.pgsql
Whole thread Raw
In response to Re: concerns around pg_lsn  (Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>)
Responses Re: concerns around pg_lsn  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On 2019-Aug-04, Jeevan Ladhe wrote:

> Sure Michael, in the attached patch I have reverted the checks from
> pg_lsn_in_internal() and added Assert() per my original patch.

Can we please change the macro definition so that have_error is one of
the arguments?  Having the variable be used inside the macro definition
but not appear literally in the call is quite confusing.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Jeevan Ladhe
Date:
Subject: Re: concerns around pg_lsn
Next
From: Daniel Migowski
Date:
Subject: Re: Patch to clean Query after rewrite-and-analyze - reduces memusageup to 50% - increases TPS by up to 50%