Re: complier warnings from ecpg tests - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: complier warnings from ecpg tests
Date
Msg-id 20190801061406.GD3435@paquier.xyz
Whole thread Raw
In response to Re: complier warnings from ecpg tests  (Sergei Kornilov <sk@zsrv.org>)
Responses Re: complier warnings from ecpg tests  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Thu, Jul 11, 2019 at 04:57:08PM +0300, Sergei Kornilov wrote:
> I use: ./configure --prefix=somepath --enable-cassert --enable-debug
> CFLAGS="-ggdb -Og -g3 -fno-omit-frame-pointer" --enable-tap-tests
> No other explicit options.

Thanks for the set of flags.  So this comes from the use of -Og, and
the rest of the tree does not complain.  The issue is that gcc
complains about the buffer not being large enough, but %d only uses up
to 2 characters so there is no overflow.  In order to fix the issue it
is fine enough to increase the buffer size to 28 bytes, so I would
recommend to just do that.  This is similar to the business done in
3a4b891.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Kohei KaiGai
Date:
Subject: Re: How to retain lesser paths at add_path()?
Next
From: Thomas Munro
Date:
Subject: Re: Add client connection check during the execution of the query