Re: BUG #15932: Module passwordcheck doesn't reference previous hooks - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: BUG #15932: Module passwordcheck doesn't reference previous hooks
Date
Msg-id 20190731073401.GB29334@paquier.xyz
Whole thread Raw
In response to Re: BUG #15932: Module passwordcheck doesn't reference previous hooks  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: BUG #15932: Module passwordcheck doesn't reference previous hooks  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-bugs
On Wed, Jul 31, 2019 at 09:23:54AM +0200, Daniel Gustafsson wrote:
> LGTM.  A small nitpick is that the below comment isn’t really giving the full
> picture, prev_check_password_hook is not just used for unload but for the hook
> chaining.

My understanding is that it's the same meaning, and also:
$ git grep "in case of unload"
contrib/auto_explain/auto_explain.c:/* Saved hook values in case of
unload */
contrib/pg_stat_statements/pg_stat_statements.c:/* Saved hook values
in case of unload */
src/test/modules/test_rls_hooks/test_rls_hooks.c:/* Saved hook values
in case of unload */
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: BUG #15932: Module passwordcheck doesn't reference previous hooks
Next
From: Daniel Gustafsson
Date:
Subject: Re: BUG #15932: Module passwordcheck doesn't reference previous hooks