Re: Compile from source using latest Microsoft Windows SDK - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Compile from source using latest Microsoft Windows SDK
Date
Msg-id 20190725000214.GC6000@paquier.xyz
Whole thread Raw
In response to Re: Compile from source using latest Microsoft Windows SDK  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: Compile from source using latest Microsoft Windows SDK  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Wed, Jul 24, 2019 at 10:38:47AM -0400, Andrew Dunstan wrote:
> Yeah, on consideration I think Peifeng's patch upthread looks OK.
> (Incidentally, this variable is not set in the very old version of VC
> running on currawong).

Interesting.  I am not actually sure in which version of VS this has
been introduced.  But it would be fine enough to do nothing if the
variable is not defined and rely on the default.  Except for the
formatting and indentation, the patch looks right.  Andrew, perhaps
you would prefer doing the final touch on it and commit it?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "Imai, Yoshikazu"
Date:
Subject: RE: seems like a bug in pgbench -R
Next
From: Andres Freund
Date:
Subject: Should we add xid_current() or a int8->xid cast?