Re: [PATCH] minor bugfix for pg_basebackup (9.6 ~ ) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] minor bugfix for pg_basebackup (9.6 ~ )
Date
Msg-id 20190724235302.GB6000@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] minor bugfix for pg_basebackup (9.6 ~ )  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [PATCH] minor bugfix for pg_basebackup (9.6 ~ )  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Wed, Jul 24, 2019 at 11:23:30AM -0400, Alvaro Herrera wrote:
> Heh, yesterday I revised the original patch as attached and was about to
> push when the bell rang.  I like this one because it keeps the comment
> to one line and it mentions the function name in charge of the
> validation (useful for grepping later on).  It's a bit laconic because
> of the long function name and the desire to keep it to one line, but it
> seems sufficient to me.

Looks fine to me.  A nit: addition of braces for the if block.  Even
if that a one-liner, there is a comment so I think that this makes the
code more readable.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Statistical aggregate functions are not working with PARTIAL aggregation
Next
From: "Imai, Yoshikazu"
Date:
Subject: RE: seems like a bug in pgbench -R