Re: Comment fix of config_default.pl - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Comment fix of config_default.pl
Date
Msg-id 20190712040113.GD2149@paquier.xyz
Whole thread Raw
In response to Comment fix of config_default.pl  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: Comment fix of config_default.pl  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
On Fri, Jul 12, 2019 at 12:15:29PM +0900, Kyotaro Horiguchi wrote:
> In src/tools/msvc/config_default.pl, parameter "perl" requires a
> path string, not a bool differently from that of configure
> script. --with-python has the same characteristics and the
> comment is suggesting that.
>
> We need to fix --with-perl and --with-uuid the same way.
>
> +    uuid      => undef,    # --with-ossp-uuid=<path>

--with-ossp-uuid is an obsolete spelling.  Wouldn't it be better to
replace it with --with-uuid=<path>?  That would be a bit inconsistent
with configure which can only take a set of hardcoded names, still
there is little point in keeping an option which would get removed
sooner than later?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Robins Tharakan
Date:
Subject: Brazil disables DST - 2019b update
Next
From: Michael Paquier
Date:
Subject: Re: Brazil disables DST - 2019b update