Re: [PATCH v5] Show detailed table persistence in \dt+ - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH v5] Show detailed table persistence in \dt+
Date
Msg-id 20190702195618.GA28184@alvherre.pgsql
Whole thread Raw
In response to Re: [PATCH v5] Show detailed table persistence in \dt+  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH v5] Show detailed table persistence in \dt+  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2019-Jul-02, Tom Lane wrote:

> * The persistence description values ought to be translatable, as
> is the usual practice in describe.c.  This is slightly painful
> because it requires tweaking the translate_columns[] values in a
> non-constant way, but it's not that bad.

LGTM.  I only fear that the cols_so_far thing is easy to break, and the
breakage will be easy to miss.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Add missing operator <->(box, point)
Next
From: Tom Lane
Date:
Subject: Re: [PATCH v4] Add \warn to psql