Re: Refactoring base64 encoding and decoding into a safer interface - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Refactoring base64 encoding and decoding into a safer interface
Date
Msg-id 20190702082229.GA2836@paquier.xyz
Whole thread Raw
In response to Re: Refactoring base64 encoding and decoding into a safer interface  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Tue, Jul 02, 2019 at 09:56:03AM +0200, Daniel Gustafsson wrote:
> I’m not sure we need to go to that length, but I don’t have overly strong
> opinions.  I think of this more like a case of “we’ve changed the API with new
> errorcases that we didn’t handle before, so we’re being a little defensive to
> help you avoid subtle bugs”.

I quite like this suggestion.

> Looks good, passes tests, provides value to the code.  Bumping this to ready
> for committer as I no more comments to add.

Thanks.  I'll look at that again in a couple of days, let's see if
others have any input to offer.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: Add parallelism and glibc dependent only options to reindexdb
Next
From: Tomas Vondra
Date:
Subject: Re: Add parallelism and glibc dependent only options to reindexdb