Postgres Pro
Downloads
Home   >   mailing lists

Re: BUG #15724: Can't create foreign table as partition - Mailing list pgsql-bugs

From Alvaro Herrera
Subject Re: BUG #15724: Can't create foreign table as partition
Date
Msg-id 20190627163332.GA30978@alvherre.pgsql
Whole thread Raw
In response to Re: BUG #15724: Can't create foreign table as partition  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: BUG #15724: Can't create foreign table as partition
List pgsql-bugs
Tree view 
On 2019-Jun-26, Amit Langote wrote:

> On Tue, Jun 25, 2019 at 9:57 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

> > BTW I'm now thinking that those ERRCODE_INVALID_OBJECT_DEFINITION codes
> > are not really the correct ones; I mean, it would be the right one to
> > use for the unexpected relkind condition, but for the other cases I
> > think we should use ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE instead.
> 
> Agreed.

I had second thoughts about this one -- ERRCODE_WRONG_OBJECT_TYPE seems
more appropriate, so I used that.

I also tweaked Fujita-san's recently committed documentation addition.

Pushed to 11 and master.  Thanks!

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #15827: Unable to connect on Windows using pg_services.conf using Python psycopg2
Next
From: Tom Lane
Date:
Subject: Re: BUG #15724: Can't create foreign table as partition