Re: BUG #15789: libpq compilation with OpenSSL 1.1.1b fails onWindows with Visual Studio 2017 - Mailing list pgsql-bugs

From Alvaro Herrera
Subject Re: BUG #15789: libpq compilation with OpenSSL 1.1.1b fails onWindows with Visual Studio 2017
Date
Msg-id 20190625135243.GA29893@alvherre.pgsql
Whole thread Raw
In response to Re: BUG #15789: libpq compilation with OpenSSL 1.1.1b fails onWindows with Visual Studio 2017  (Michael Paquier <michael@paquier.xyz>)
Responses Re: BUG #15789: libpq compilation with OpenSSL 1.1.1b fails onWindows with Visual Studio 2017
List pgsql-bugs
On 2019-Jun-25, Michael Paquier wrote:

> Attached is an updated version which I would be fine to commit.  I
> have tested it with compilation linking to OpenSSL 1.0.2 and 1.1.0 on
> Win32 and the build is able to complete.  This applies on HEAD only,
> where I have run all my tests.  The patch is properly indented.

In sub GenerateFiles, I would move the stanza for ->{openssl} next to
the one for ->{gss} and keep the simpler lines all together (your patch
leaves ->{nls} as a separate item, which is aesthetically unpleasing).

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-bugs by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: BUG #15724: Can't create foreign table as partition
Next
From: Kassym Dorsel
Date:
Subject: Re: BUG #15869: Custom aggregation returns null when parallelized