Re: pgsql: Avoid spurious deadlocks when upgrading a tuple lock - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Avoid spurious deadlocks when upgrading a tuple lock
Date
Msg-id 20190614153736.GA21626@alvherre.pgsql
Whole thread Raw
In response to Re: pgsql: Avoid spurious deadlocks when upgrading a tuple lock  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 2019-Jun-14, Tom Lane wrote:

> I wrote:
> >> Hm, I don't get that warning.  Does this patch silence it, please?
> 
> > Uh, no patch attached?  But initializing the variable where it's
> > declared would certainly silence it.
> 
> BTW, after looking around a bit I wonder if this complaint isn't
> exposing an actual logic bug.  Shouldn't skip_tuple_lock have
> a lifetime similar to first_time?

I think you're right.  I should come up with a test case that exercises
that case.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Silence compiler warning
Next
From: Tom Lane
Date:
Subject: pgsql: First-draft release notes for 11.4.