Re: BUG #15833: defining a comment on a domain constraint fails withwrong OID - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: BUG #15833: defining a comment on a domain constraint fails withwrong OID
Date
Msg-id 20190610062855.GE2199@paquier.xyz
Whole thread Raw
In response to Re: BUG #15833: defining a comment on a domain constraint fails withwrong OID  (Michael Paquier <michael@paquier.xyz>)
Responses Re: BUG #15833: defining a comment on a domain constraint fails withwrong OID
List pgsql-bugs
On Fri, Jun 07, 2019 at 02:42:33PM +0900, Michael Paquier wrote:
> Well, it wouldn't be a problem to do a syscache lookup and then use
> the type from contypid, no?  It seems to me that it would be more
> consistent to just add a pg_domain_constraint_ownercheck() in aclchk.c
> as all the syscache lookups happen their for all the other objects
> types.  What do you think?

Attached is what I have in mind.  There are already tests at the
bottom of constraints.source checking for comments on both table and
domain constraints, so my proposal is to run them with a dedicated
role.  What do you think?
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: Fahar Abbas
Date:
Subject: Re: BUG #15834: Cannot install npgsql driver
Next
From: Daniel Gustafsson
Date:
Subject: Re: BUG #15833: defining a comment on a domain constraint fails withwrong OID