Re: Cleaning up and speeding up string functions - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Cleaning up and speeding up string functions
Date
Msg-id 20190605205424.GA15382@alvherre.pgsql
Whole thread Raw
In response to Re: Cleaning up and speeding up string functions  (David Rowley <david.rowley@2ndquadrant.com>)
Responses Re: Cleaning up and speeding up string functions
List pgsql-hackers
On 2019-May-26, David Rowley wrote:

> On Sun, 26 May 2019 at 04:50, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> > Here the cost is code space rather than programmer-visible complexity,
> > but I still doubt that it's worth it.
> 
> I see on today's master the postgres binary did grow from 8633960
> bytes to 8642504 on my machine using GCC 8.3, so you might be right.
> pg_receivewal grew from 96376 to 96424 bytes.

I suppose one place that could be affected visibly is JSON object
construction (json.c, jsonfuncs.c) that could potentially deal with
millions of stringinfo manipulations, but most of those calls don't
actually use appendStringInfoString with constant values, so it's
probably not worth bothering with.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Why does pg_checksums -r not have a long option?
Next
From: Alvaro Herrera
Date:
Subject: Re: crash testing suggestions for 12 beta 1