Re: Sort support for macaddr8 - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Sort support for macaddr8
Date
Msg-id 20190604213735.GA31158@alvherre.pgsql
Whole thread Raw
In response to Re: Sort support for macaddr8  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: Sort support for macaddr8
List pgsql-hackers
On 2019-Jun-03, Peter Geoghegan wrote:

> As you know, it's a bit weird that we're proposing adding sort support
> with abbreviated keys for a type that is 8 bytes, since you'd expect
> it to also be pass-by-value on most platforms, which largely defeats
> the purpose of having abbreviated keys (though sort support could
> still make sense, for the same reason it makes sense to have it for
> int8). However, macaddr8 isn't actually pass-by-value, and it seems
> too late to do anything about that now, so abbreviated keys actually
> make sense.

I'm not sure I understand why you say it's too late to change now.
Surely the on-disk representation doesn't actually change, so it is not
impossible to change?  And you make it sound like doing that change is
worthwhile, performance-wise.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Chapman Flack
Date:
Subject: Re: Binary support for pgoutput plugin
Next
From: Andres Freund
Date:
Subject: Re: Sort support for macaddr8