Re: coverage additions - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: coverage additions
Date
Msg-id 20190530192805.GA25189@alvherre.pgsql
Whole thread Raw
In response to Re: coverage additions  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2019-May-30, Tom Lane wrote:

> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > I just enabled --enabled-llvm on the coverage reporting machine, which
> > made src/backend/jit/jit.c go from 60/71 % (line/function wise) to 78/85 % ...
> > and src/backend/jit/llvm from not appearing at all in the report to
> > 78/94 %.  That's a good improvement.
> 
> > If there are other obvious improvements to be had, please let me know.
> 
> I was going to suggest that adding some or all of
> 
> -DCOPY_PARSE_PLAN_TREES
> -DWRITE_READ_PARSE_PLAN_TREES
> -DRAW_EXPRESSION_COVERAGE_TEST
> 
> to your CPPFLAGS might improve the reported coverage in backend/nodes/,
> and perhaps other places.

I did that, and it certainly increased backend/nodes numbers
considerably.  Thanks.

(extensible.c remains at 0% though, as does its companion nodeCustom.c).

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Larry Rosenman
Date:
Subject: Re: New committer: David Rowley
Next
From: Alvaro Herrera
Date:
Subject: Re: coverage additions