Postgres Pro
Downloads
Home   >   mailing lists

Re: ClonedConstraint typedef is dead code? - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: ClonedConstraint typedef is dead code?
Date
Msg-id 20190515191940.GA6777@alvherre.pgsql
Whole thread Raw
In response to ClonedConstraint typedef is dead code?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: ClonedConstraint typedef is dead code?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On 2019-May-15, Tom Lane wrote:

> catalog/pg_constraint.h defines a typedef ClonedConstraint,
> which AFAICS is no longer referenced anywhere.  Is there a
> reason not to remove it?

Oh, I didn't realize it had become completely unused!  It was used for
FK creation in partitioned tables, but we rewrote that code completely
and I don't foresee needing that struct for anything in the future, so
it seems safe to remove.

Thanks,

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Are ctid chaining loops safe without relation size checks?
Next
From: Tomas Vondra
Date:
Subject: Re: Replace hashtable growEnable flag