Re: PG12, PGXS and linking pgfeutils - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: PG12, PGXS and linking pgfeutils
Date
Msg-id 20190513195851.GA10077@alvherre.pgsql
Whole thread Raw
In response to Re: PG12, PGXS and linking pgfeutils  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: PG12, PGXS and linking pgfeutils  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2019-May-13, Tom Lane wrote:

> I started working on a patch to do that, and soon noticed that there
> are pre-existing files logging.[hc] in src/bin/pg_rewind/.  This seems
> like a Bad Thing, in fact the #includes in pg_rewind/ are already a
> little confused due to this.  I think we should either rename those
> two pg_rewind files to something else, or rename the generic ones,
> perhaps to "fe_logging.[hc]".  The latter could be done nearly
> trivially as part of the movement patch, but on cosmetic grounds
> I'd be more inclined to do the former instead.  Thoughts?

I'd rename both :-)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: What is an item pointer, anyway?
Next
From: Robert Haas
Date:
Subject: Re: remove doc/bug.template?