On Sat, May 11, 2019 at 10:36:13AM -0400, Bruce Momjian wrote:
> On Fri, May 10, 2019 at 07:31:21PM -0700, Peter Geoghegan wrote:
> > > I think I have understood the nuances, as listed above --- I just don't
> > > agree with the solution.
> >
> > To be clear, I don't expect you to agree with the solution.
> >
> > Another thing that you missed from my patch is that bugfix commit
> > 9b10926263d831fac5758f1493c929a49b55669b shouldn't be listed.
>
> Why should it not be listed?
Thinking some more, I try to aggregate all the feature addition commits
together, but often skip "cleanups" of previous feature additions. Are
you saying that 9b10926263d831fac5758f1493c929a49b55669b is a cleanup,
and not part of the feature addition? It was not clear to me of
9b10926263d831fac5758f1493c929a49b55669b was a further enhancement
made possible by previous commits, or a "fix" for a previous commit.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +