On 2019-May-09, Tom Lane wrote:
> I'm not especially on board with the idea of moving FE-specific error
> handling code into libpgcommon, as that breaks the concept that
> src/common/ is broadly for code that can work in either frontend or
> backend contexts. However, we already have a few violations of that
> rule: common/Makefile already has
>
> # A few files are currently only built for frontend, not server
> OBJS_FRONTEND = $(OBJS_COMMON) fe_memutils.o file_utils.o restricted_token.o
>
> So maybe the answer is to move these logging support functions into
> src/common, in a file that's only built for frontend.
I wonder if a better solution isn't to move the file_utils stuff to
fe_utils. Half of it is frontend-specific. The only one that should be
shared to backend seems to be fsync_fname ... but instead of sharing it,
we have a second copy in fd.c.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
