Re: vacuumdb and new VACUUM options - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: vacuumdb and new VACUUM options
Date
Msg-id 20190509010056.GA14573@paquier.xyz
Whole thread Raw
In response to Re: vacuumdb and new VACUUM options  (Euler Taveira <euler@timbira.com.br>)
Responses Re: vacuumdb and new VACUUM options  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
On Wed, May 08, 2019 at 06:21:09PM -0300, Euler Taveira wrote:
> Em qua, 8 de mai de 2019 às 14:19, Fujii Masao <masao.fujii@gmail.com> escreveu:
>> The question is; we should support vacuumdb option for (1), i.e.,,
>> something like --index-cleanup option is added?
>> Or for (2), i.e., something like --disable-index-cleanup option is added
>> as your patch does? Or for both?
>
> --index-cleanup=BOOL

I agree with Euler's suggestion to have a 1-1 mapping between the
option of vacuumdb and the VACUUM parameter, because that's more
intuitive:
- --index-cleanup=3Dfalse =3D> VACUUM (INDEX_CLEANUP=3Dfalse)
- --index-cleanup=3Dtrue =3D> VACUUM (INDEX_CLEANUP=3Dtrue)
- no --index-cleanup means to rely on the reloption.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "Matsumura, Ryo"
Date:
Subject: RE: Patch: doc for pg_logical_emit_message()
Next
From: Michael Paquier
Date:
Subject: Re: Wrong return code in vacuumdb when multiple jobs are used