Re: copy-past-o comment in lock.h - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: copy-past-o comment in lock.h
Date
Msg-id 20190507080024.GP1499@paquier.xyz
Whole thread Raw
In response to copy-past-o comment in lock.h  (John Naylor <john.naylor@2ndquadrant.com>)
Responses Re: copy-past-o comment in lock.h  (John Naylor <john.naylor@2ndquadrant.com>)
List pgsql-hackers
On Tue, May 07, 2019 at 03:41:50PM +0800, John Naylor wrote:
> Attached is an attempt to match surrounding code. More broadly,
> though, it seems the "ID info" comments belong with the SET_LOCKTAG_*
> macros rather than with the LockTagType enum members.

+   LOCKTAG_SPECULATIVE_TOKEN,  /* for speculative insertion */
+   /* ID info for a speculative token is TRANSACTION info + token */
Shouldn't the first comment be just "speculative insertion"?  And the
second one "ID info for a speculative insertion is transaction ID +
its speculative insert counter"?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: New vacuum option to do only freezing
Next
From: John Naylor
Date:
Subject: Re: copy-past-o comment in lock.h